SNAFU in Quake 2

[X7[Q2C]]

Looking at the Quake 2 Source Code,
some of the maps are f* up with the coop starts,
so they add code to fix the errors.
And the security.bsp does not have any.

Gross, ugly, disgustuing hack section

this function is an ugly as hell hack to fix some map flaws
the coop spawn spots on some maps are SNAFU. There are coop spots
with the wrong targetname as well as spots with no name at all
we use carnal knowledge of the maps to fix the coop spot targetnames to match
that of the nearest named single player spot

//
// Gross, ugly, disgustuing hack section
//
// this function is an ugly as hell hack to fix some map flaws
//
// the coop spawn spots on some maps are SNAFU.  There are coop spots
// with the wrong targetname as well as spots with no name at all
//
// we use carnal knowledge of the maps to fix the coop spot targetnames to match
// that of the nearest named single player spot

static void SP_FixCoopSpots (edict_t *self)
{
edict_t *spot;
vec3_t d;

spot = NULL;

while(1)
{
spot = G_Find(spot, FOFS(classname), "info_player_start");
if (!spot)
return;
if (!spot->targetname)
continue;
VectorSubtract(self->s.origin, spot->s.origin, d);
if (VectorLength(d) < 384)
{
if ((!self->targetname) || Q_stricmp(self->targetname, spot->targetname) != 0)
{
// gi.dprintf("FixCoopSpots changed %s at %s targetname from %s to %s\n", self->classname, vtos(self->s.origin), self->targetname, spot->targetname);
self->targetname = spot->targetname;
}
return;
}
}
}

// now if that one wasn't ugly enough for you then try this one on for size
// some maps don't have any coop spots at all, so we need to create them
// where they should have been

static void SP_CreateCoopSpots (edict_t *self)
{
edict_t *spot;

if(Q_stricmp(level.mapname, "security") == 0)
{
spot = G_Spawn();
spot->classname = "info_player_coop";
spot->s.origin[0] = 188 - 64;
spot->s.origin[1] = -164;
spot->s.origin[2] = 80;
spot->targetname = "jail3";
spot->s.angles[1] = 90;

spot = G_Spawn();
spot->classname = "info_player_coop";
spot->s.origin[0] = 188 + 64;
spot->s.origin[1] = -164;
spot->s.origin[2] = 80;
spot->targetname = "jail3";
spot->s.angles[1] = 90;

spot = G_Spawn();
spot->classname = "info_player_coop";
spot->s.origin[0] = 188 + 128;
spot->s.origin[1] = -164;
spot->s.origin[2] = 80;
spot->targetname = "jail3";
spot->s.angles[1] = 90;

return;
}
}


/*QUAKED info_player_start (1 0 0) (-16 -16 -24) (16 16 32)
The normal starting point for a level.
*/
void SP_info_player_start(edict_t *self)
{
if (!coop->value)
return;
if(Q_stricmp(level.mapname, "security") == 0)
{
// invoke one of our gross, ugly, disgusting hacks
self->think = SP_CreateCoopSpots;
self->nextthink = level.time + FRAMETIME;
}
}

/*QUAKED info_player_deathmatch (1 0 1) (-16 -16 -24) (16 16 32)
potential spawning position for deathmatch games
*/
void SP_info_player_deathmatch(edict_t *self)
{
if (!deathmatch->value)
{
G_FreeEdict (self);
return;
}
SP_misc_teleporter_dest (self);
}

/*QUAKED info_player_coop (1 0 1) (-16 -16 -24) (16 16 32)
potential spawning position for coop games
*/

void SP_info_player_coop(edict_t *self)
{
if (!coop->value)
{
G_FreeEdict (self);
return;
}

if((Q_stricmp(level.mapname, "jail2") == 0)   ||
  (Q_stricmp(level.mapname, "jail4") == 0)   ||
  (Q_stricmp(level.mapname, "mine1") == 0)   ||
  (Q_stricmp(level.mapname, "mine2") == 0)   ||
  (Q_stricmp(level.mapname, "mine3") == 0)   ||
  (Q_stricmp(level.mapname, "mine4") == 0)   ||
  (Q_stricmp(level.mapname, "lab") == 0)     ||
  (Q_stricmp(level.mapname, "boss1") == 0)   ||
  (Q_stricmp(level.mapname, "fact3") == 0)   ||
  (Q_stricmp(level.mapname, "biggun") == 0)  ||
  (Q_stricmp(level.mapname, "space") == 0)   ||
  (Q_stricmp(level.mapname, "command") == 0) ||
  (Q_stricmp(level.mapname, "power2") == 0) ||
  (Q_stricmp(level.mapname, "strike") == 0))
{
// invoke one of our gross, ugly, disgusting hacks
self->think = SP_FixCoopSpots;
self->nextthink = level.time + FRAMETIME;
}
}



[spirit]

[Whirlingdervish]

so that would be why there have been very few co-oop mods that were actually stable..


no wonder!

[Paril]

..yeah, and? This fix was made in 3.19 or 3.20 (can't remember), that's why it's a hack. They didn't want to re-make the actual bsp files (from the version before and this one, it would make the maps incompatible, so this was the easiest way for them).

-Paril

[Whirlingdervish]

couldn't they have released .ent files to overwrite the maps' problems?

or were they implemented later?

I know .bsp.override files are a pretty recent occurence..

[Paril]

.override is just a fancy way of saying .ent. There ain't nothing recent about them.

the .ent system wasn't made till a year or so after 3.20's final release, and I'm sure ID never thought of making it.

-Paril